Validate attached volume types for cross-HV resize - #657
Open
anokfireball wants to merge 1 commit into
Open
Conversation
Change-Id: I6103d68443bb422ad203a44c3145bdb8c1632379
anokfireball
force-pushed
the
fix/cross-hv-attached-volume-type-check
branch
from
August 21, 2026 09:33
3e72d93 to
b4046dd
Compare
anokfireball
marked this pull request as ready for review
August 24, 2026 08:51
| bdms = self._get_bdms() | ||
| return bdms.root_bdm() | ||
|
|
||
| def _get_cross_hv_expected_volume_type(self): |
There was a problem hiding this comment.
Can we cache the result? Volume types should be basically static and I don't think we should rely on the configured volume type becoming available after we rolled out Nova.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cross-HV resize supports only FCD-backed Cinder volumes at this time.
This change uses the newly introduced
[cross_hv] fcd_volume_typeto validate all attached Cinder volumes during cross-HV resize. Nova now rejects the resize if any attached volume does not use the configured FCD volume type. This covers:Same-HV resize behavior does not change. We currently only have one FCD volume type.